voxpupuli / puppet-prometheus

Puppet module for prometheus
https://forge.puppet.com/puppet/prometheus
Apache License 2.0
59 stars 237 forks source link

node_exporter.pp does not provide direct way to override the listening port #692

Open lchopfpt opened 10 months ago

lchopfpt commented 10 months ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

Can't provide a negative. While there's the ability to change "scrape_port" which is used to provide an exported resource to prometheus server, that scrape_port value is not used elsewhere, so then node_exporter still listens on its default.

What are you seeing

No override of the listening port in a direct manner that will update both runtime setting of web.listen-address and scrape_port.
It can be provided as part of "extra_options" but then one must still also update scrape_port too.

What behaviour did you expect instead

To be able to set one value for port and have it reflect in the runtime of the service and its listening port as well as what is exported as a resource to prometheus server.

Output log

Any additional information you'd like to impart