voxpupuli / puppet-prometheus

Puppet module for prometheus
https://forge.puppet.com/puppet/prometheus
Apache License 2.0
59 stars 237 forks source link

make statsd exporter mappings optional #721

Open chadh opened 2 months ago

chadh commented 2 months ago

Pull Request (PR) description

This PR addresses Issue #680

This Pull Request (PR) fixes the following issues

Makes statsd exporter mappings optional (so you can provide your own config)

binford2k commented 2 months ago

Hey @chadh! Close enough, so fill out this form if you'd like to claim your May the Source Be With You sticker! https://forms.office.com/r/Cn55uJmWMH

chadh commented 2 months ago

lol. what great timing! Now I'm gonna have to actually add tests so I won't feel too guilty.

TheMeier commented 1 month ago

@chadh please update REFERENCE.md, see https://voxpupuli.org/docs/how_to_run_tests/

TheMeier commented 1 month ago

Hm, I think new parameter manage_mappings would be easier to understand. In any case I think some documentation is needed