search

voxpupuli / puppet-prometheus

Puppet module for prometheus
https://forge.puppet.com/puppet/prometheus
Apache License 2.0
59 stars 237 forks source link

modulesync 9.0.0 #738

Closed bastelfreak closed 3 weeks ago

bastelfreak commented 3 weeks ago

modulesync 9.0.0

TheMeier commented 3 weeks ago

rebased

TheMeier commented 3 weeks ago

Well this uncovered another issue. It seems that the checks in https://github.com/voxpupuli/puppet-prometheus/blob/master/spec/classes/prometheus_spec.rb#L371-L478 have not been executed before. I guess because facts[:service_provider] == 'systemd' was not true. I will provide another PR to fix these tests. Sadly that uncovered an issue with the defaults for prometheus::server::bin_dir on archlinux: The lookup of the hiera data for prometheus::server::bin_dir has precedence over the parameter passed to prometheus::bin_dir