modulesync 2.11.0 - Githubissues

voxpupuli / puppet-puppetwebhook

Manage the installation and configuration of the puppet_webhook gem

Apache License 2.0

0 stars 7 forks source link

modulesync 2.11.0 #23

Closed baurmatt closed 4 years ago

baurmatt commented 4 years ago

modulesync 2.8.0

baurmatt commented 4 years ago

If I get this right, the failing jobs are because sidekiq 6 got released which requires Ruby >= 2.5. This isn't provided by Puppet 5 AIO packages.

Not sure how we should fix this. I see the following options:

Drop Puppet 5 support
Make webhook require sidekiq < 6
?

baurmatt commented 4 years ago

Opened https://github.com/voxpupuli/puppet_webhook/issues/104 for this.

bastelfreak commented 4 years ago

the module was initially created with pdk, so I'm not sure if modulesyncing is a good idea.

dhollinger commented 4 years ago

Let's revisit modulesync at a later date, but for now leave it as a PDK module. The larger community needs to have a discussion around how to make our modules play well with both PDK-using devs and non-PDK using devs.