search

voxpupuli / puppet-puppetwebhook

Manage the installation and configuration of the puppet_webhook gem
Apache License 2.0
0 stars 7 forks source link

support puppet-webhook v2, drop V1 support #25

Closed bastelfreak closed 3 years ago

bastelfreak commented 3 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

bastelfreak commented 3 years ago

I'm still working on this. I just didn't mark it as draft because I want travis to test it

bastelfreak commented 3 years ago

the acceptance tests fail on centos because a gem is missing in the rpm:

Sep 09 08:15:19 centos7-64-1 systemd[1]: Started Puppet Webhook Web Application.
Sep 09 08:15:19 centos7-64-1 bundle[5945]: bundler: failed to load command: puma (/opt/voxpupuli/webhook/bin/puma)
Sep 09 08:15:19 centos7-64-1 bundle[5945]: Bundler::GemNotFound: Could not find bcrypt-3.1.13 in any of the sources
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/spec_set.rb:86:in `block in materialize'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/spec_set.rb:80:in `map!'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/spec_set.rb:80:in `materialize'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/definition.rb:170:in `specs'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/definition.rb:237:in `specs_for'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/definition.rb:226:in `requested_specs'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/runtime.rb:101:in `block in definition_method'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/runtime.rb:20:in `setup'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler.rb:149:in `setup'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/setup.rb:20:in `block in <top (required)>'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/ui/shell.rb:136:in `with_level'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/ui/shell.rb:88:in `silence'
Sep 09 08:15:19 centos7-64-1 bundle[5945]: /opt/voxpupuli/webhook/lib/ruby/gems/2.6.0/gems/bundler-2.1.4/lib/bundler/setup.rb:20:in `<top (required)>'
Sep 09 08:15:19 centos7-64-1 systemd[1]: puppet-webhook-app.service: main process exited, code=exited, status=1/FAILURE
Sep 09 08:15:19 centos7-64-1 systemd[1]: Unit puppet-webhook-app.service entered failed state.
Sep 09 08:15:19 centos7-64-1 systemd[1]: puppet-webhook-app.service failed.

this is produced by puppet-webhook-2.1.3-1.el7.x86_64. I can confirm that puppet-webhook-2.1.3rc3-1.el7.x86_64 works, but that's not yet available in the repos.

bastelfreak commented 3 years ago

sweet. so this PR showed at least two issues in our redis module:

I will provide patches

Dan33l commented 3 years ago

It looks that Redis have som trouble to start. I tested locally with Docker on Ubuntu 18-04 and all tests passed.

I suppose it is related to ipv6 settings : https://stackoverflow.com/questions/50668845/cannot-install-redis-server-on-ubuntu-18-04 I have part of ipv6 available in my testing env, and it looks not enabled at all in travis CI env : https://travis-ci.org/github/voxpupuli/puppet-puppetwebhook/jobs/727176974#L1324

vox-pupuli-tasks[bot] commented 3 years ago

Dear @bastelfreak, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks

bastelfreak commented 3 years ago

I will merge this now and cleanup the puppet-strings documentation in a followup PR.