search

voxpupuli / puppet-pxe

Puppet module for deploying a PXE boot server
https://forge.puppet.com/puppet/pxe
51 stars 38 forks source link

RHEL missing wget and fixing syslinux_major_version #56

Closed mikerenfro closed 4 years ago

mikerenfro commented 4 years ago

Pull Request (PR) description

First, RHEL's recommended minimal package group does not include wget. Ensuring it's installed before any of the exec resources are applied. If the package resource is enough on its own, could remove the dependency.

Second, it appears the code to find syslinux_major_version is missing a group for its back-reference. Also adjusted the regex to allow for major versions higher than 9.

This Pull Request (PR) fixes the following issues

N/A

bastelfreak commented 4 years ago

Instead of all the exec resources with wget and the issues with the package resource, what about just migrate it to archive ?

mikerenfro commented 4 years ago

Looks like that might be workable. Going to separate these into two separate PRs, since the syslinux regex one is unrelated, and the wget fix will be a bit more complicated than I'd first planned.