voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 371 forks source link

pip resource requirements cause dependency cycle #509

Open ruanda opened 4 years ago

ruanda commented 4 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

If you create venvs in two different modules which depend on each other and install packages via python::pip, dependency cycle appears as all venvs are requirements for each python::pip.

What behaviour did you expect instead

Python:;pip should depend only on venvs it uses.

Any additional information you'd like to impart

Affecting lines start at https://github.com/voxpupuli/puppet-python/blob/master/manifests/pip.pp#L75. Those collectors should probably limit venv by path.