search

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 371 forks source link

Ensure curl package #536

Open sp-ricard-valverde opened 4 years ago

sp-ricard-valverde commented 4 years ago

https://github.com/voxpupuli/puppet-python/blob/adf223e5c03c9f3cc0e59d233e9ed08768fc38d4/manifests/pip/bootstrap.pp#L36

This assumes curl is installed, but it should be added as a package requirement. Furthermore the command will return a 0 successful code if the python binary is present but curl is not, masking the failure and making puppet think the Exec resource applied successfully.

Same here: https://github.com/voxpupuli/puppet-python/blob/adf223e5c03c9f3cc0e59d233e9ed08768fc38d4/manifests/pip/bootstrap.pp#L52