search

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 375 forks source link

fix virtualenv deprecated "--no-site-packages" argument #552

Closed saz closed 3 years ago

saz commented 4 years ago

--no-site-packages argument isn't available in all versions of virtualenv > 20.0.1

saz commented 4 years ago

Type annotations would indeed help here a bit and I was thinking about it.

Is there a plan on adding them? Maybe this part can be marked as "needs some work" after annotations are there.

I'm also curious on how many users are still using virtualenv < 1.7...

igalic commented 4 years ago

I'm also curious on how many users are still using virtualenv < 1.7...

file this under "things i don't wanna know", like, how many people still use CentOS / RHEL 5

saz commented 4 years ago

@thebigb @igalic Does it makes sense to still support virtualenv < 1.7? 1.7 has been released in 2011... Dropping support will make this waaay easier...

igalic commented 4 years ago

i think that mostly depends on what the oldest operating system is that ships it, before we get to update it

thebigb commented 4 years ago

Personally not a big fan of potentially breaking changes unless it's a major release. That said, I doubt that users that are running older versions do keep this puppet module up to date.

I had a look at the changelog you found, and I guess this solution would suffice:

https://github.com/voxpupuli/puppet-python/compare/master...thebigb:master?diff=unified

saz commented 4 years ago

i think that mostly depends on what the oldest operating system is that ships it, before we get to update it

That's the hardest part to find, as not all OSs have a version stated somewhere related to virtualenv. The usual suspects (e.g. RHEL) seem to have a newer version included (CentOS 5 isn't in the list of supported OSs :smile:)

@thebigb Okay, let's use this one. Should I update this PR or how should we proceed?

thebigb commented 4 years ago

Go ahead. Did you test it? I tested it on my local setup, but I might've overlooked something.

crazymind1337 commented 4 years ago

@igalic @thebigb @saz how do we process here? I would like to have this released soon, since we require python virtualenv support on 20.04.

crazymind1337 commented 4 years ago

@saz you might need to rebase your branch.

crazymind1337 commented 4 years ago

@saz @thebigb can we have this release soon please?

PeterJCLaw commented 3 years ago

Looks like a variant of this was included in https://github.com/voxpupuli/puppet-python/pull/593; is this sorted now?

saz commented 3 years ago

Looks good to me. Closing this.