Add python-venv installation

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.

https://forge.puppetlabs.com/puppet/python

Apache License 2.0

199 stars 370 forks source link

Add python-venv installation #579

Closed crazymind1337 closed 2 years ago

crazymind1337 commented 3 years ago

Pull Request (PR) description

If you use python::pyvenv you require the package python-venv (name differs on OSes). This has been missing.

bastelfreak commented 3 years ago

@crazymind1337 can you please rebase against our latest master branch?

crazymind1337 commented 3 years ago

@crazymind1337 can you please rebase against our latest master branch?

Done.

bastelfreak commented 3 years ago

can you take a look at the failing tests? They are passing on master

crazymind1337 commented 3 years ago

Oh yes. Will be done next week.

crazymind1337 commented 2 years ago

Looks like I forgot something :D

crazymind1337 commented 2 years ago

It would break it so far, if you already have defined a Package[python3-venv] resource, you would run into a duplicate resource. But this is what the fix is for.