Fix python::virtualenv to allow virtualenv to not require absolute path

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.

https://forge.puppetlabs.com/puppet/python

Apache License 2.0

199 stars 370 forks source link

Fix python::virtualenv to allow virtualenv to not require absolute path #592

Closed treydock closed 3 years ago

treydock commented 3 years ago

Pull Request (PR) description

I maintain several modules where I might do something like virtualenv => 'virtualenv-3' and that works just fine and doesn't require me to know the full path on each OS. Also the default value if undef is just virtualenv so doesn't make sense to require the non-default values be more restrictive than the default.

bastelfreak commented 3 years ago

@treydock can you maybe add a test that enforces it's just a string? Otherwise I'm friend this gets changed to Stdlib::Absolutepath soonish again

treydock commented 3 years ago

@bastelfreak Added unit tests for virtualenv.