search

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 370 forks source link

Support Ubuntu 20.04 #593

Closed treydock closed 3 years ago

treydock commented 3 years ago

Pull Request (PR) description

Add support for Ubuntu 20.04. Had to force virtualenv to not use distribute otherwise produces errors. Also updated virtualenv tests to consistently use Python 3 since first set of tests did this but subsequent tests did not and that broke some OS acceptance tests.

This Pull Request (PR) fixes the following issues

Replaces #576

treydock commented 3 years ago

Looks like the Ubuntu 20.02 & Puppet 5 acceptance failure was networking issues boostrapping the beaker nodeset. Will need to be rerun.

bastelfreak commented 3 years ago

Ubuntu 29 + puppet 5 is expected to fail because puppet does not provide packages fro them :(

treydock commented 3 years ago

Looks like majority of tests are failing virtualenv with this error:

        Notice: /Stage[main]/Main/Python::Virtualenv[venv]/Exec[python_virtualenv_/opt/venv6]/returns:     AttributeError: module 'importlib._bootstrap' has no attribute 'SourceFileLoader'

After much googling at least with Ubuntu 20.04 the online solutions did not work. The only way around it was not trying to install distribute pip package so forcing distribute => false for python::virtualenv. I'm wondering if that should become the new default because majority of OSes with Python 3 seem to not work with distribute => true.

treydock commented 3 years ago

@bastelfreak I am not real familiar with how voxpupuli modulesync sets up setfiles for acceptance, my exclude didn't seem to take. I think the hash used to define matrix causes issues with being able to exclude elements

bastelfreak commented 3 years ago

we havn't figured out yet how to exclude sets :(

bastelfreak commented 3 years ago

@crazymind1337 can you take a look as well?

bastelfreak commented 3 years ago

@treydock can you rebase against master to get rid of the merge commit?

treydock commented 3 years ago

@bastelfreak I had done a merge to get in the virtualenv unit tests which needed to be adjusted for this pull request. Looks to have resolved the conflicts.

crazymind1337 commented 3 years ago

Tested on latest ubuntu:20.04 docker container with puppet6. Works for me!

crazymind1337 commented 3 years ago

@treydock You still have to fix the Commit messages. It looks like there is something wrong.

crazymind1337 commented 3 years ago

@treydock You still have to fix the Commit messages. It looks like there is something wrong.

Nevermind. I will squash it.