search

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 375 forks source link

Add the possibility to specify the pip version in virtual envs #599

Closed SaschaDoering closed 3 years ago

SaschaDoering commented 3 years ago

Pull Request (PR) description

Hello,

there is already a pullrequest (https://github.com/voxpupuli/puppet-python/pull/558) that has been opened for https://github.com/voxpupuli/puppet-python/issues/559. But since September 2020 no further progress can be seen. Since this is currently blocking me a bit, I have tried myself on a solution. I hope that's the right way in this case. I'll add the possibility to set the pip version in virtual envs to bypass a general update to latest. Currently it fails on some of our older Ubuntu installations and can be prevented by specifying a version.

Please let me know if I can support here with some more information.

Thanks

This Pull Request (PR) fixes the following issues

Fixes #559

SaschaDoering commented 3 years ago

I'm not sure, but the CI for Puppet 5 on Ubuntu 20.04 failed probably because of a mistake that has nothing to do with my change. The two CIs for Ubuntu 16.04 fail with the error that is the reason for my change. This could be fixed by setting the Pip version. Should I put this in the Acceptance Tests only for Ubuntu 16.04? Or should I rather not fix it so that the tests are not pinned to an old Pip version?

kenyon commented 3 years ago

I'm not sure, but the CI for Puppet 5 on Ubuntu 20.04 failed probably because of a mistake that has nothing to do with my change. The two CIs for Ubuntu 16.04 fail with the error that is the reason for my change. This could be fixed by setting the Pip version. Should I put this in the Acceptance Tests only for Ubuntu 16.04? Or should I rather not fix it so that the tests are not pinned to an old Pip version?

Yes, we do need the tests to pass.

SaschaDoering commented 3 years ago

Thanks for your review @kenyon. I fixed the CIs for Ubuntu 16.04 by pinning the Pip version. The tests for Ubuntu 20 & Puppet 5 continues to fail with a network error. This seems to me to be a bug that I can't fix in this module. Or do I oversee something here?

kenyon commented 3 years ago

Thanks for your review @kenyon. I fixed the CIs for Ubuntu 16.04 by pinning the Pip version. The tests for Ubuntu 20 & Puppet 5 continues to fail with a network error. This seems to me to be a bug that I can't fix in this module. Or do I oversee something here?

Yes, Puppet 5 on Ubuntu 20.04 always fails because there are no Puppet 5 packages for Ubuntu 20.04, but we have no way to exclude this combination from the test matrix.

crazymind1337 commented 3 years ago

@kenyon Can you merge the PR since already have approved it?

crazymind1337 commented 3 years ago

I will merge this soon since it already has been approved by two persons despite I am from the same company like the requester.