search

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 375 forks source link

Delete the never released any_puppet_to_python() function #620

Closed smortex closed 3 years ago

smortex commented 3 years ago

It was integrated into the stdlib as to_python():

Label this PR as skip-changelog since no release of the module ship with this function. #616 which introduced the function has also been labeled skip-changelog.

ghoneycutt commented 3 years ago

This has not been released yet into a tagged version of stdlib. When it is, this PR will need to update the metadata.json to show the minimum requirement.

smortex commented 3 years ago

Technically, this module does not need/use/rely on this function, that's why this removal of a function is not a backward-incompatible change.

Modules which want to use this function will indeed have to update the minimum version of stdlib accordingly when a release is made (just as they would have had to update the minimum version of the python module if the function was release in the python module).

ghoneycutt commented 3 years ago

Ah right! Suggest adding a note in the README that these functions are removed and you need version X of stdlib.

smortex commented 3 years ago

Ah right! Suggest adding a note in the README that these functions are removed and you need version X of stdlib.

Sorry, I think I failed to explain my point. What I mean was that no release of the python module shipped with these functions: they only landed in the master branch, never got released, and are now removed. So I we are not supposed to have any consumer for these functions who are surprised by the deletion :smiley: