search

voxpupuli / puppet-python

Puppet module for installing and managing Python, pip, virtualenvs and Gunicorn virtual hosts.
https://forge.puppetlabs.com/puppet/python
Apache License 2.0
199 stars 370 forks source link

Correct FreeBSD Python package name #688

Open rtprio opened 4 months ago

rtprio commented 4 months ago

Pull Request (PR) description

When trying to install Puppetboard I ran into this module trying to install virtualenv (doesn't exist as a package, only a port) and py3.9-pip (correct name is py39-pip).

Replace out the . in the version name. I did not test this extensively, just enough to get it to compile and install the right package for puppetboard. The origination of of the module doesn't seem to allow an easy way to get a default version based on OS and pass it down to python, pip, etc.

Feedback welcome.

smortex commented 4 months ago

Regarding the version, I never hit that issue. It happen I use this in my python profile:

class profile::python {
  class { 'python':
    version => '39',
    dev     => 'present',
  }
}

The data type for the version parameter accept a large number of formats, maybe too much.

The other change seems unrelated and break CI. Maybe worth a different PR?