voxpupuli / puppet-r10k

Setup and configure r10k for use with git based environments in puppet
https://forge.puppet.com/puppet/r10k
Apache License 2.0
98 stars 168 forks source link

Using exec in run_command replaces process and skips notify_* calls #441

Closed legooolas closed 5 years ago

legooolas commented 6 years ago

The run_command function uses exec with a backgrounded command (using &) to run the desired command, which cannot get the exit status of the command, and also replaces the running webhook binary (forked from the parent) with this command.

This means that anything expected to run after calling run_command no longer works.

Not sure if the affected Puppet, Ruby, OS etc versions are required, but here's what I'm using currently:

How to reproduce:

What are you seeing:

Expected behaviour:

stanleyz commented 6 years ago

458

I fixed that in #458 waiting for merge