search

voxpupuli / puppet-rabbitmq

RabbitMQ Puppet Module
http://forge.puppetlabs.com/puppet/rabbitmq
Apache License 2.0
171 stars 500 forks source link

Improve test coverage #1028

Closed wyardley closed 1 week ago

wyardley commented 1 week ago

Pull Request (PR) description

Improve test coverage in main class spec

Resolves some basic coverage issues reported at the end of unit test runs.

Before:

Coverage Report:

Total resources:   38
Touched resources: 33
Resource coverage: 86.84%

 Untouched resources:
  Class[Rabbitmq::Management]
  Exec[remove_old_rabbitmqadmin_on_upgrade]
  Exec[rpm --import https://github.com/rabbitmq/signing-keys/releases/download/2.0/rabbitmq-release-signing-key.asc]
  Exec[rpm --import https://packagecloud.io/rabbitmq/rabbitmq-server/gpgkey]
  File[/usr/local/bin/rabbitmqadmin]

After:

Coverage Report:

Total resources:   32
Touched resources: 32
Resource coverage: 100.00%

Could potentially be some branches that could be covered better, but overall, this seems like a Good Thing (TM).

This Pull Request (PR) fixes the following issues

wyardley commented 1 week ago

I'm trying to add some additional coverage for one other thing, but I'm seeing some quirks with it, so I'll PR separately.