search

voxpupuli / puppet-rabbitmq

RabbitMQ Puppet Module
http://forge.puppetlabs.com/puppet/rabbitmq
Apache License 2.0
171 stars 500 forks source link

Fix Test #976

Closed Valantin closed 6 months ago

Valantin commented 7 months ago

Pull Request (PR) description

initial refactoring of acceptance fix test failing on puppet 8 remove unused erlang module from fixture bump dependency version

This Pull Request (PR) fixes the following issues

Fixes #965

wyardley commented 7 months ago

Thanks for taking a look at this.

Just a heads up before you get too deep into this -- I'm not sure if this will be easy to get working without #926 or something like it.

Also, the issue in some of the failing tests with the cluster being reported as rabbitmq vs rabbitmq_cluster is odd (and showed up in some other recent PRs as well) - I took a quick look at it and seems like the test explicitly specifies the cluster name as rabbitmq_cluster, so the most likely reason is that since we're still using the Linux distribution's rmq version in the tests that this behavior may have changed in a newer version.

I haven't had luck getting the acceptance tests for puppet to work locally in a while (can get them to start and then certain OSes just crash outright on my machine using the Docker version of the beaker tests), so it's been hard to figure out some of the issues that are ongoing.

As far as the erlang module, there was a goal of switching to the vox module in #955 and that's been also stalled by some of these continuing / circular issues.

I don't use puppet or rabbitmq and haven't for quite a few years now, but I'm happy to provide any help that I can in terms of helping move any of these ongoing efforts forward.

Valantin commented 7 months ago

Thanks for the resources to start. Idealy OS package was self consistent, so the erlang version shipped was the correct one for the rabbimq-server version.

The erlang module was used only on acceptance test, I've already use it on on ubuntu 22.04 in my production cloud, and I hate the repository because in one year the have dropped support for erlang version I use, and I've updated all my cluster to add a new node. Not so happy in a production environment.

My idea was to fix acceptance using the os package (if possible) to add new OS support For example no "official" external repos was available for debian 12 at this moment, but i'm pretty sure you can run correctly with the system version.

Valantin commented 7 months ago

@bastelfreak I've rebased on modulesync branch, hope Is a better solution to use the modulesync 7.3 test

wyardley commented 6 months ago

Hi @Valantin Are you still working on this?

Valantin commented 6 months ago

Yes and no, I'm switched to other things. But in my todolist, I need more time to check OS related things, for example the EL approch in 8 and 9 release.

wyardley commented 6 months ago

Probably not needed with #985 etc