search

voxpupuli / puppet-rabbitmq

RabbitMQ Puppet Module
http://forge.puppetlabs.com/puppet/rabbitmq
Apache License 2.0
171 stars 500 forks source link

Use stdlib::ensure_packages #990

Closed wyardley closed 6 months ago

wyardley commented 6 months ago

Pull Request (PR) description

Resolve deprecation errors by using ensure_packages() from stdlib vs. from Puppet

  Warning: This function is deprecated, please use stdlib::ensure_packages instead. at ["/etc/puppetlabs/code/environments/production/modules/rabbitmq/manifests/install/rabbitmqadmin.pp", 14]:["/etc/puppetlabs/code/environments/production/modules/rabbitmq/manifests/init.pp", 574]

This Pull Request (PR) fixes the following issues

wyardley commented 6 months ago

@bastelfreak does this make sense? seems like ensure_packages existed even in the oldest version we support?

So far, I didn't see any other deprecated stdlib methods? Not sure if you'd like to increase the min version for it anyway as a breaking change?

TheMeier commented 6 months ago

replacing ensure_packages by stdlib::ensure_packages makes perfectly sense