voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

redis disable snapshots #321

Open rmalenko opened 5 years ago

rmalenko commented 5 years ago
  1. Disable AOF by setting the appendonly configuration directive to no (it is the default value)
  2. Disable RDB snapshotting by disabling (commenting out) all of the save configuration directives (there are 3 that are defined by default)

I have changed for Redis 5.5 this template redis.conf.erb to have uncommented this string save ""

# Save the DB on disk:
# ...
#   It is also possible to remove all the previously configured save
#   points by adding a save directive with a single empty string argument
#   like in the following example:
#
#   save ""

<% if @save_db_to_disk %>
    <%- @save_db_to_disk_interval.sort_by{|k,v|k}.each do |seconds, key_change| -%>
    save <%= seconds -%> <%= key_change -%> <%= "\n" -%>
<%- end -%>
    <% else %>save ""
<% end %>
jeandoBet commented 3 years ago

Hi,

Any update on this ? Will it be implemented ?

Thanks,

cjacobsatnwea commented 1 year ago

There is a lot more options/etc in redis than this module provides. I have worked around this in my local work by:

example of the insertion logic (however you add to the redis.conf is up to reader):

        notify      => Service['redis'],
        refreshonly => true,
        subscribe   => Exec['cp -p /etc/redis/redis.conf.puppet /etc/redis/redis.conf'],

paths might be different for your configs, and above could use vars defining those of course.

your exec could even be a cli command removing/replacing a config entry: sed -i 's/^save.*/save ""/g' /etc/redis/redis.conf for this specific case - don't even need your own .conf to add on. :)

ThiefMaster commented 1 year ago

I'll use my own template. But seriously, this issue is open for nearly 4 years now. Can't something as trivial as this be implemented?!

(someone who cares enough should probably open a PR though ;))

kenyon commented 1 year ago

I'll use my own template. But seriously, this issue is open for nearly 4 years now. Can't something as trivial as this be implemented?!

Not if nobody creates a pull request.