Use Puppet-Datatype Sensitive for $masterauth and $auth_pass

voxpupuli / puppet-redis

Puppet Module to manage Redis

https://forge.puppet.com/puppet/redis

Apache License 2.0

40 stars 183 forks source link

Use Puppet-Datatype Sensitive for $masterauth and $auth_pass #403

Closed cocker-cc closed 3 years ago

cocker-cc commented 3 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ekohl commented 3 years ago

Looks like there's a merge conflict now. Would you mind rebasing?

cocker-cc commented 3 years ago

Looks like there's a merge conflict now. Would you mind rebasing?

Done.

cocker-cc commented 3 years ago

Should we also set show_diff on the file resource if the value was passed in as Sensitive? I think something like this should work:
file { '...':
  show_diff => $var !~ Sensitive,
}

With EPP instead of ERB the file-Resource would behave automatically. I created this PR for therefor.

ekohl commented 3 years ago

Needs a rebase now that that PR is merged.

cocker-cc commented 3 years ago

rebase

Done.

ekohl commented 3 years ago

Thanks!