voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

Ability to disable slowlog_log_slower_than #404

Closed mattpascoe closed 3 years ago

mattpascoe commented 3 years ago

Currently the code requires an integer for slowlog_log_slower_than as indicated here:

https://github.com/voxpupuli/puppet-redis/blob/d33892c573d9df29b37ba79dd7077a09554f6d8f/manifests/init.pp#L311

However there are times you would want to disable slowlog all together. The way to do this is to pass in '-1' which puppet complains is not an integer.

Please allow for '-1' values in this field. I'm not sure if there are other features that can be disabled in this way, so that might be worth a look?

For reference on the disable option: https://help.compose.com/docs/redis-slow-logs#slowlog-log-slower-than