search

voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

Honor redis::sentinel::package_ensure #413

Closed kajinamit closed 3 years ago

kajinamit commented 3 years ago

Pull Request (PR) description

This change ensures that the package_ensure parameter is properly used in the redis::sentinel class

This Pull Request (PR) fixes the following issues

The package_ensure parameter of the redis_sentinel class is supposed to define status of the redis-sentinel package but in fact it is not used. This fixes the ignored parameter.

Also, default of the parameter is updated following the recent change of redis::package_ensure. This is required to avoid conflicting declaration of redis package caused by a different status; 'installed' vs 'present'.

root-expert commented 3 years ago

Hello @kajinamit, thanks for the contribution! Can you add a unit test for this?