search

voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

Support Debian 11 #415

Closed root-expert closed 2 years ago

root-expert commented 3 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ekohl commented 3 years ago

Looks like it fails on installing bolt because the package is not available. I couldn't find an issue on https://tickets.puppet.com but that may just be my limited JIRA search skills.

root-expert commented 3 years ago

Looks like it fails on installing bolt because the package is not available. I couldn't find an issue on https://tickets.puppet.com but that may just be my limited JIRA search skills.

Yea, there isn't a Puppet Server package as well. Let's give them some time :smile:

root-expert commented 3 years ago

The problem with this PR seems to be deeper, that's why I haven't progress it further.

For example daemonize = yes doesn't play well with systemd Type=notify which makes sense. I'm really wondering how this is working for other OSes.

Setting Type=forking makes test to pass. Don't if we should change this for the rest of the OSes or make Type field configurable by the user. That way they can select their Type/daemonize combination that fits their needs.

ekohl commented 3 years ago

My ideal goal for this module was to leverage instances of redis-server@.service which is shipped on Debian & Ubuntu. For example on Ubuntu 18.04:

# dpkg -L redis-server | grep .service
/lib/systemd/system/redis-server.service
/lib/systemd/system/redis-server@.service

It's not shipped on Debian 9, but we can drop Debian 9 support now that it's only maintained as LTS (as opposed to the Debian project itself).

Then we would get out of the business of managing systemd files. An additional benefit is that you would get the security hardening that's in place.

Sadly on Red Hat-based distros this isn't shipped. That can be solved by shipping a redis@.service just for EL though.

The migration may also be complex so I never got around to it, but that's the vision I had. We should probably write it down in an issue.

root-expert commented 3 years ago

I don't see those systemd files shipped on my Ubuntu 20.04 boxes.

Also dunno how flexible is that when you want to run multiple redis servers on the same box. PR #424 low key adds supports to it by writing lock and PID files to separate directories I think.

ekohl commented 3 years ago

I don't see those systemd files shipped on my Ubuntu 20.04 boxes.

That's odd because I just installed redis-server on an Ubuntu 20.04 container and they were there.

kenyon commented 3 years ago

Should be there: https://packages.ubuntu.com/focal/amd64/redis-server/filelist