voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

CentOS9/RHEL9: Migrate configuration files to /etc/redis #434

Closed kajinamit closed 2 years ago

kajinamit commented 2 years ago

Pull Request (PR) description

Recent update in CentOS 9 Stream changed paths where configuration files are installed and now these files are placed under /etc/redis (since redis 6.0.9-2)[1].

This change updates the paths according to that migration[2].

[1] https://gitlab.com/redhat/centos-stream/rpms/redis/-/blob/8d691e9f5a8e9e01a060b624c40ff19680b6472e/redis.spec#L346 [2] https://gitlab.com/redhat/centos-stream/rpms/redis/-/commit/617715f9dabf108b475902585b9fc5283c0670da

This Pull Request (PR) fixes the following issues

n/a

kajinamit commented 2 years ago

CI is failing because of an issue with puppet-epel, which I'm fixing in https://github.com/voxpupuli/puppet-epel/pull/134 .

ekohl commented 2 years ago

Just thinking out loud here: we don't need to ensure the old file is absent since there are few in place upgrades with EL. And if people do use leapp, leapp should take care of the move.

ekohl commented 2 years ago

I'm looking at the code, but Redis is included in EL8 and EL9 so why do we still require EPEL in preinstall.pp on those OSes? We should also modify our helper to use the preinstall class. This probably means installing additional modules since they're soft dependencies. I opened https://github.com/voxpupuli/puppet-redis/pull/435. This does not yet exclude EPEL from EL8/EL9 (or rather, limit it to EL7), but it would be a good start for this.

ekohl commented 2 years ago

Could you rebase this? I merged #435 and that should work. It removes the dependency on EPEL altogether for non-EL7.

kajinamit commented 2 years ago

Bleh, looks like bolt isn't built for EL9. From one problem to the next ... Personally I don't care for bolt and would be OK with excluding that on EL9 for now. Do you agree? Perhaps it also needs a ticket @ https://tickets.puppet.com/

Yeah I think that's reasonable. I've created a ticket to request puppet-bolt builds for CentOS 9, which I also mentioned in code comments.

https://tickets.puppetlabs.com/browse/MODULES-11275