search

voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

Add support for managing Redis dnfmodule on EL 8+ #450

Closed ehelms closed 2 years ago

ehelms commented 2 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ehelms commented 2 years ago

I can't seem to see what I am missing to make the requires relationship work in testing:

  1) redis on centos-8-x86_64 without parameters with manage_dnf_module true is expected to contain Package[redis dnf module] that comes before Package[redis]
     Failure/Error: it { is_expected.to contain_package('redis dnf module').with_ensure('6').that_comes_before('Package[redis]') }
       expected that the catalogue would contain Package[redis dnf module] with that comes before Package[redis]
     # ./spec/classes/redis_spec.rb:98:in `block (6 levels) in <top (required)>'

  2) redis on centos-9-x86_64 without parameters with manage_dnf_module true is expected to contain Package[redis dnf module] that comes before Package[redis]
     Failure/Error: it { is_expected.to contain_package('redis dnf module').with_ensure('6').that_comes_before('Package[redis]') }
       expected that the catalogue would contain Package[redis dnf module] with that comes before Package[redis]
     # ./spec/classes/redis_spec.rb:98:in `block (6 levels) in <top (required)>'

  3) redis on redhat-8-x86_64 without parameters with manage_dnf_module true is expected to contain Package[redis dnf module] that comes before Package[redis]
     Failure/Error: it { is_expected.to contain_package('redis dnf module').with_ensure('6').that_comes_before('Package[redis]') }
       expected that the catalogue would contain Package[redis dnf module] with that comes before Package[redis]
     # ./spec/classes/redis_spec.rb:98:in `block (6 levels) in <top (required)>'

  4) redis on redhat-9-x86_64 without parameters with manage_dnf_module true is expected to contain Package[redis dnf module] that comes before Package[redis]
     Failure/Error: it { is_expected.to contain_package('redis dnf module').with_ensure('6').that_comes_before('Package[redis]') }
       expected that the catalogue would contain Package[redis dnf module] with that comes before Package[redis]
ehelms commented 2 years ago

To address the failing unit tests that are unrelated -- https://github.com/voxpupuli/puppet-redis/pull/452