search

voxpupuli / puppet-redis

Puppet Module to manage Redis
https://forge.puppet.com/puppet/redis
Apache License 2.0
40 stars 183 forks source link

Support for Redis v6+ ACL auth #527

Open mrsteffenjo opened 3 months ago

mrsteffenjo commented 3 months ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

Can't find parameter with name masteruser when searching the repo.

What are you seeing

Zero matches

What behaviour did you expect instead

As of Redis 6 when ACL was introduced and sentinel got support for the following parameters:

Redis: masterauth masteruser

Sentinel sentinel auth-user sentinel auth-pass

So I expect to be able to specify this for sentinel and redis replicas and so on.

mrsteffenjo commented 3 months ago

I've opened two PR's: #528 and #529, the only difference is that the last one does not treat the parameters as sensitive types.

mrsteffenjo commented 3 months ago

What are the next steps and what is the expected timeline for?

yakatz commented 3 months ago

I am not a Redis expert, but I had a quick look. You can sometimes get a quick review by posting on Slack.