search

voxpupuli / puppet-rhsm

Puppet module for registering systems with RedHat.
https://forge.puppet.com/puppet/rhsm
Apache License 2.0
6 stars 23 forks source link

Add syspurpose entries to facts #129

Closed jcpunk closed 4 months ago

jcpunk commented 2 years ago

Pull Request (PR) description

This should parse out the syspurpose.json if defined and add those entries to the facts reported.

This Pull Request (PR) fixes the following issues

Fixes: #120

vchepkov commented 2 years ago

I am a big proponent of using module namespace to avoid clashing, if somebody already created similar fact. I am not sure if it is set as a standard somewhere, but this notation seems to be reasonable https://github.com/voxpupuli/puppet-extlib/blob/master/lib/facter/extlib__puppet_config.rb#L3

jcpunk commented 2 years ago

Since I'm looking to extend the existing fact, I'm not sure switching to a namespaced version is the right way to go...