search

voxpupuli / puppet-rhsm

Puppet module for registering systems with RedHat.
https://forge.puppet.com/puppet/rhsm
Apache License 2.0
6 stars 23 forks source link

Allow the user/pw or org/key to be Deferred. #135

Closed tedgarb closed 10 months ago

tedgarb commented 1 year ago

Pull Request (PR) description

This introduces conditional logic to detect if sensitive/secret values may be passed in as Deferred type, and if so to process them entirely through a chain of Deferred arguments, to address issues with interpolating Deferred into strings on the compiler.

Unfortunately, there is no way at the moment to pass a parameter of type Deferred into puppet-rspec, so while this has been tested and verified locally, there is not currently a unit test for this new functionality.

This Pull Request (PR) fixes the following issues

n/a

tedgarb commented 10 months ago

Thank you for merging my other PR. Any idea if this one can be merged as well while you are working in this repo?

tedgarb commented 10 months ago

Rebased this PR and took @kenyon suggestion through the whole file re: variable reuse. Thanks for the tip, I knew you could do that in ruby but didn't realize it worked in puppet manifests.