voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

Remove service_manage, make service_config and service_script optional #355

Closed wyardley closed 6 years ago

wyardley commented 6 years ago

Remove service_manage param, make service_config and service_script optional

Service_manage was not really used for the purpose you'd expect (and was not documented). This PR removes it, and just makes service_config and service_script optional params which will not do anything if unset (default).

Since the service was actually managed either way before, I decided against repurposing this param to control whether the service was managed or not. We could easily add a different param later to control this if we really wanted to make managing the service completely optional (with class containment, vs. in the class).