I think this should accomplish a fix to #303, and somewhat improves test coverage, though there's room for more improvement.
The reason the existing tests worked is that the stubbed in data matches rspec-puppet-facts's $fqdn fact (h/t to Johnson Earls for that gem, as well as for a couple other useful improvements to these changes). This should handle the case where the user overrides framework.server.hostname a little more magically than before (though perhaps not the case where the user wishes to override framework.server.url directly?)
I think this should accomplish a fix to #303, and somewhat improves test coverage, though there's room for more improvement.
The reason the existing tests worked is that the stubbed in data matches rspec-puppet-facts's $fqdn fact (h/t to Johnson Earls for that gem, as well as for a couple other useful improvements to these changes). This should handle the case where the user overrides
framework.server.hostnamea little more magically than before (though perhaps not the case where the user wishes to overrideframework.server.urldirectly?)