voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

Fix PR #392 + added rundeck_commitid fact #402

Closed smasa90 closed 5 years ago

smasa90 commented 5 years ago

Pull Request (PR) description

This PR fixes rebase needed of PR #392 Added another fact : rundeck_commitid

This Pull Request (PR) fixes the following issues

This PR fixes rebase needed of PR #392 Added another fact : rundeck_commitid

bastelfreak commented 5 years ago

Hi @smasa90. Can you please take a look at the failing travis job and add a unit test for this?

smasa90 commented 5 years ago

@bastelfreak Sorry, forgot to push :/ Added unit test for these facts at same time. Don't have idea why my test file don't cover all the tested file, would you mind just to throw an eye on it ?