search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

[FR] Change rundeck-config.erb to key,value iterator only pattern #406

Closed TheMeier closed 9 months ago

TheMeier commented 5 years ago

The rundec-config.erb limits the values that can be set to the ones pre-defined. IMHO it would make much more sense to simply use something like this and removing any logic from the templates

<%- @config.sort.each do |k,v| -%>
<%= k %> = "<%= v %>"
<%- end -%>
bastelfreak commented 5 years ago

Hi @TheMeier, thanks for the issue. It's a common pattern to add a Hash as parameter and at the end of the config file, iterate on the hash (but keep the current parameters). Would you like to provide a PR for this?

TheMeier commented 5 years ago

Sure. There is already such a hash iterator at the end, sadly its called gui_config with comment Hash of properties for customizing the [Rundeck GUI]

How a bout deprecating the current parameters?

bastelfreak commented 5 years ago

deprecating them would mean a breaking change. I would prefer it to just add a generic hash option where we iterate on.