voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

Add parameter for webhooks activation #427

Closed AlexandrePicosson closed 4 years ago

AlexandrePicosson commented 4 years ago

Pull Request (PR) description

This pull request allow to enable the webhooks feature as described in Rundeck documentation.

This Pull Request (PR) fixes the following issues

n/a

AlexandrePicosson commented 4 years ago

Lint fails on :

manifests/config/global/project.pp:37:variable_scope:WARNING:top-scope variable being used without an explicit namespace manifests/config/global/project.pp:46:variable_scope:WARNING:top-scope variable being used without an explicit namespace manifests/config/global/project.pp:55:variable_scope:WARNING:top-scope variable being used without an explicit namespace

But I did not edit this file at all, I would appreciate some indications.

danifr commented 4 years ago

Very strange indeed. I even ran the travis test locally and I didn't get any error...

pccibot commented 4 years ago

Dear @AlexandrePicosson, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @AlexandrePicosson, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @AlexandrePicosson, thanks for the PR!

This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

vox-pupuli-tasks[bot] commented 4 years ago

Dear @AlexandrePicosson, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? If you need any help, you can reach out to us on our IRC channel voxpupuli on Freenode or our Slack channel voxpupuli at slack.puppet.com. You can find my sourcecode at voxpupuli/vox-pupuli-tasks