Add config support for Hashicorp Vault plugin

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool

https://forge.puppet.com/puppet/rundeck

MIT License

39 stars 129 forks source link

Add config support for Hashicorp Vault plugin #430

Closed linuxmail closed 4 years ago

linuxmail commented 4 years ago

Pull Request (PR) description

This PR adds support for the the Vault plugin, which can be used as key storage provider.

This Pull Request (PR) fixes the following issues

Fixes: #428

bastelfreak commented 4 years ago

Hi @linuxmail, thanks for the PR! Can you please take a look at the inline comments I did and also check the used email address in the commits? It isn't associated with your github account.

linuxmail commented 4 years ago

Hi,

I've added the fixes and looking later for other kind of stuff to do. Hopefully the mail address is also set on the Git repo :-)

linuxmail commented 4 years ago

I had to set the Vault entries to Optional, otherwise Travis wasn't happy ("..expected String, got undef..."

bastelfreak commented 4 years ago

Thanks for the PR!