search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

Add required Vault api version to template #432

Closed linuxmail closed 9 months ago

linuxmail commented 4 years ago

Pull Request (PR) description

In the PR for #430, the API version was missing. For newer installation we have to set it to "2", which should be default for the Vault plugin anyway, but is seems, that this is not the case, so we have to set it explicit, otherwise we get "permission denied" messages in the Vault access logs.

ghoneycutt commented 4 years ago

This looks good, just needs a test. This could be a one liner that tests that the contents of the template are rendered correctly. Have a look at https://github.com/voxpupuli/puppet-rundeck/blob/523a03cca67d681254c8c8b5c738e12a5c172eb9/spec/classes/config/global/rundeck_config_spec.rb for examples.

Joris29 commented 9 months ago

@kenyon This is fixed by #523