search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

Make preauthentication based on headers optional #441

Closed nbarrientos closed 9 months ago

nbarrientos commented 4 years ago

Pull Request (PR) description

Users might only want to configure preauthentication using request attributes, without making use of any header. The issue is that in that scenario setting the header-related settings to empty values seems to break things. I think it's probably a good idea to set them only if the relevant keys are present in preauthenticated_config.

nbarrientos commented 4 years ago

Ready to be reviewed.

nbarrientos commented 4 years ago

Similar to https://github.com/voxpupuli/puppet-rundeck/pull/439. I think it's fine to keep the redirectUrl setting as is.

bastelfreak commented 4 years ago

thanks for the work @nbarrientos . can you please add tests that verify if the filecontent is present/absent?

nbarrientos commented 4 years ago

Hi @bastelfreak

Thanks for your comments. I've added a test context to make sure that the corresponding lines are not included if the keys are not present in the config hash. The opposite case is already covered by the tests as both keys are set in the default configuration (see rundeck::config::global::rundeck_config class without any parameters on).

Btw, I'd suggest to close https://github.com/voxpupuli/puppet-rundeck/pull/439.

vox-pupuli-tasks[bot] commented 2 years ago

Dear @nbarrientos, thanks for the PR!

This is Vox Pupuli Tasks, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase?

You can find my sourcecode at voxpupuli/vox-pupuli-tasks

Joris29 commented 9 months ago

@kenyon This is fixed by #523