feat(log4j): (optional) disable DailyRollingFileAppender

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool

https://forge.puppet.com/puppet/rundeck

MIT License

39 stars 130 forks source link

feat(log4j): (optional) disable DailyRollingFileAppender #447

Closed zebraartefakt closed 8 months ago

zebraartefakt commented 4 years ago

Pull Request (PR) description

Introduces new optional variable rd_log4j_rotatedaily (default=true). This is needed for users that prefer logrotate over log4j.

This Pull Request (PR) fixes the following issues

n/a

bastelfreak commented 4 years ago

Hi, thanks for the PR! Can you please take a look at the failing tests and also and new ones for the new parameter?

zebraartefakt commented 4 years ago

I've made the changes @bastelfreak suggested. I've also fixed the issues with the test, but there's still a single failing test. The error message isn't exactly helpful, but it doesn't look like it's related to my changes.

bastelfreak commented 4 years ago

I restarted the failed test and it succeeded. Can you please add a test for your change?

kenyon commented 8 months ago

Obsoleted by #520.