search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 130 forks source link

jobs #458

Closed jwbraucher closed 5 months ago

jwbraucher commented 3 years ago

Pull Request (PR) description

Adds support for installing the rundeck cli and using it to create rundeck jobs.

This Pull Request (PR) fixes the following issues

Fixes #33

ghoneycutt commented 3 years ago

@jwbraucher Thank you for your contribution! We appreciate new functionality though cannot merge without tests. Could you please add tests.

Check out https://github.com/voxpupuli/puppet-rundeck/blob/master/spec/defines/config/project_spec.rb as an example for a defined type.

Joris29 commented 8 months ago

@kenyon I would like to add this cli option i was wondering about the approach and i would like your opinion on it. Let me explain what i'm wondering about so rundeck and rundeck-cli both have different life-cycle and can be used separately. So i'm wondering should we really include it in the rundeck class or have a complete separate class or even a separate module?

kenyon commented 8 months ago

@Joris29 I'd go with include in the rundeck class or a separate class, probably doesn't make sense to have a dedicated module, but I don't use rundeck so whatever makes most sense for you.

Joris29 commented 8 months ago

Alright then I will go for a separate class for the cli and work something out