voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 130 forks source link

a colon is added to realm.properties file even when auth_users hash is empty #459

Closed overag3 closed 3 years ago

overag3 commented 3 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

Leave default value of auth_users empty hash in params.pp file

What are you seeing

During puppet run, a colon is added to realm.properties file even when auth_users hash is empty

What behaviour did you expect instead

No adding colon in realm.properties file when auth_users hash is empty

Output log

root@rundeck:~# puppet agent -t
Info: Using configured environment 'production'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Retrieving locales
Info: Loading facts
Info: Caching catalog for host.fr
Info: Applying configuration version '1609834470'
Notice: /Stage[main]/Rundeck::Config/File[/etc/rundeck/realm.properties]/content: 
--- /etc/rundeck/realm.properties       2021-01-05 08:14:15.420569659 +0000
+++ /tmp/puppet-file20210105-709138-18ngwpe     2021-01-05 08:14:38.684656640 +0000
@@ -23,3 +23,4 @@
 # This sets the default user accounts for the Rundeck app
 #
 admin:OBF:<password>,user,admin,architect,deploy,build
+:

Info: Computing checksum on file /etc/rundeck/realm.properties
Info: /Stage[main]/Rundeck::Config/File[/etc/rundeck/realm.properties]: Filebucketed /etc/rundeck/realm.properties to puppet with sum b79658964203e9a86372022719ed2913
Notice: /Stage[main]/Rundeck::Config/File[/etc/rundeck/realm.properties]/content: 

Notice: /Stage[main]/Rundeck::Config/File[/etc/rundeck/realm.properties]/content: content changed '{md5}b79658964203e9a86372022719ed2913' to '{md5}63ab3afb8fa83b454e23d13410851123' (corrective)
Info: Class[Rundeck::Config]: Scheduling refresh of Class[Rundeck::Service]
Info: Class[Rundeck::Service]: Scheduling refresh of Service[rundeckd]
Notice: /Stage[main]/Rundeck::Service/Service[rundeckd]: Triggered 'refresh' from 1 event
Notice: Applied catalog in 7.92 seconds