voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 130 forks source link

add package name param to init.pp and install.pp #470

Open ethan-riskiq opened 3 years ago

ethan-riskiq commented 3 years ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

kenyon commented 3 years ago

Can you also add this parameter to the README? We really should be reformatting the documentation to use Puppet Strings, and refactor to eliminate the params.pp pattern, but IMO those can be separate efforts.

kenyon commented 3 years ago

Would also be great if you could add a test of this parameter.

ethan-riskiq commented 3 years ago

Sure, will do.