voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 130 forks source link

Add sensitive option for database_config #482

Closed Joris29 closed 1 year ago

Joris29 commented 2 years ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

database_config => { 'type' => 'postgresql', 'url' => "jdbc:postgresql://${db_host}/${_servername}", 'username' => $db_username, 'password' => $db_password.unwrap, 'driverClassName' => 'org.postgresql.Driver', },

What are you seeing

Notice: /Stage[main]/Rundeck::Config::Global::Rundeck_config/File[/etc/rundeck/rundeck-config.groovy]/content: --- /etc/rundeck/rundeck-config.groovy 2022-01-11 09:02:27.648577738 +0100 +++ /tmp/puppet-file20220111-42398-1beilhv 2022-01-11 09:06:00.912297639 +0100 @@ -12,7 +12,7 @@ url = "jdbc:postgresql://localhost/rundeck" driverClassName = "org.postgresql.Driver" username = "my_user" '-' password = "my_pass" '+' password = "my_password" dialect = "" }

What behaviour did you expect instead

Notice: /Stage[main]/Rundeck::Config::Global::Rundeck_config/File[/etc/rundeck/rundeck-config.groovy]/content: value [redacted]

Output log

Any additional information you'd like to impart

root-expert commented 2 years ago

Hello @Joris29 , can you provide a PR to address this issue?

Joris29 commented 2 years ago

It was more like a request but i'll check if i can provide a PR for it

Joris29 commented 1 year ago

@root-expert could you take a look at the PR?

nosrio commented 1 year ago

Hi! Could someone please review my PR? Regards

Joris29 commented 1 year ago

@bastelfreak Could someone pls look into this, the issue has be open for quite some time multiple solutions have been provided but no feedback so far.