voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 129 forks source link

RSpec error if used with inifile >= 4.2.0 #496

Closed atsonkov closed 1 year ago

atsonkov commented 1 year ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

.fixtures.yml containing:

fixtures:
  forge_modules:
    inifile:
      repo: "puppetlabs/inifile"
      ref: "5.4.0"
    rundeck:
      repo: "puppet/rundeck"
      ref: "7.0.0"

RSpec test containing:

  it { is_expected.to compile }

What are you seeing

Error in the rspec test when trying to compile catalog with certain combination of module versions.

What behavior did you expect instead

The module including compatible versions of rundeck and inifile should compile without issues.

Output log

  1) INTERNAL_PROFILE on redhat-7-x86_64 with custom hieradata is expected to compile into a catalogue without dependency cycles
     Failure/Error: it { is_expected.to compile }
       error during compilation: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, deprecation. create_ini_settings. This method is deprecated, please use inifile::create_ini_settings instead. at [".../spec/fixtures/modules/rundeck/manifests/config/project.pp", 181]: (file: .../spec/fixtures/modules/rundeck/manifests/config/project.pp, line: 181, column: 3) (file:.../spec/fixtures/modules/INTERNAL_PROFILE/manifests/server/projects.pp, line: 24) on node node.example.com
     # ./spec/classes/init_spec.rb:17:in `block (5 levels) in <top (required)>'

Any additional information you'd like to impart