search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 128 forks source link

Add syncLdapUser param to security_config #511

Closed nosrio closed 1 year ago

nosrio commented 1 year ago

Pull Request (PR) description

Add rundeck.security.syncLdapUser to rundeck_config.groovy file. This flag enable using LDAP user attributes to update the email, first name, and last name properties of your Rundeck users. Add ldap user attributes used to source the email, and name properties. Remove un used templates.

ref: https://docs.rundeck.com/docs/administration/security/authentication.html#ldap

This Pull Request (PR) fixes the following issues

Fixes #510 Fixes #416

nosrio commented 1 year ago

Adding some tests.

nosrio commented 1 year ago

@bastelfreak I can't seems to find why some tests are failling, could you give me a hand?

kenyon commented 1 year ago

Failure/Error: apply_manifest(pp, catch_changes: true)

This is the second run, to check for idempotency. Something is changing during that run.

nosrio commented 1 year ago

I believe that these checks started failling when #502 was merged. In fact, that PR do not have all checks passed.

I am triying to debug why the second run is not idempotent but it is not related to the changes on thisI think.

nosrio commented 1 year ago

@bastelfreak can you help me to solve this errors?

nosrio commented 1 year ago

@bastelfreak please review

nosrio commented 1 year ago

Done @bastelfreak :)