search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 128 forks source link

Fix ACLs rendering when using attributes as filters #513

Closed nosrio closed 1 year ago

nosrio commented 1 year ago

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Fixes #391 Fixes #512

nosrio commented 1 year ago

@bastelfreak Please review this. The same check from #511 are failing, could you help me fix them?

bastelfreak commented 1 year ago

mhm I've no idea why it fails :( I asked on IRC.

nosrio commented 1 year ago

As @jay7x mentioned

H2 db removed support for MVCC in 1.4.200 release. Spring-boot 2.2.2 uses same version of H2 DB. To resolve this issue remove “MVCC=true” option from ‘spring.datasource.url’ in application.properties file.

Removing MVCC=true from database_config.url seems to be working.

jay7x commented 1 year ago

I'm not sure if it's ok to blindly remove it.. I guess H2 DB is bundled with Rundeck. If so then it'd be better to recheck which version has H2 DB version >= 1.4.198. Then add/remove MVCC=true based on the version. But I'm not a rundeck user so just my 2$c here :)

nosrio commented 1 year ago

From this and this I understand that is not really necessary to have the setting MVCC=true if using everthing as default.

nosrio commented 1 year ago

@bastelfreak do you think this PR is ready to merge?