search

voxpupuli / puppet-rundeck

Module for managing the installatation and configuration of the rundeck orchestration tool
https://forge.puppet.com/puppet/rundeck
MIT License
39 stars 130 forks source link

Fix debian gpg validation and improve rundeck::install spec file #528

Closed Joris29 closed 5 months ago

Joris29 commented 6 months ago

Pull Request (PR) description

This PR will fix the debian gpg validation and will improve the rundeck install spec file

Joris29 commented 6 months ago

@kenyon I tried with several approaches but it keeps failing any idea why?

kenyon commented 6 months ago

Not sure if I'm constructing the URL properly, but this gives a 404: https://packages.rundeck.com/pagerduty/rundeck/any/dists/main/InRelease

Joris29 commented 6 months ago

Are you trying to get the deb package or the gpg key?

kenyon commented 6 months ago

Trying to get the InRelease file to manually verify it like curl 'https://deb.debian.org/debian-security/dists/bullseye-security/InRelease' | gpg --verify.

Joris29 commented 6 months ago

script.deb.sh.txt This is the script that rundeck recommends on using for their deb packages And this is the url that lists all the packages https://packages.rundeck.com/pagerduty/rundeck

Joris29 commented 6 months ago

@kenyon Using the old apt method with ID and keyserver seem to work for most debian tests but not sure what's wrong with the rest of the tests

Joris29 commented 5 months ago

@kenyon I managed to pin down the failing tests to one. Rundeck released a new major version and this is causing some issues so i locked it to two 4.17 version in the unit tests, which seem to resolve most issues.

Joris29 commented 5 months ago

@kenyon The issue is resolved by added the raw key content in hiera, it's still strange that source doesn't work then as it is the same key maybe this has to be investigated?