search

voxpupuli / puppet-rvm

A puppet module for installing and using RVM (Ruby Version Manager)
https://forge.puppet.com/puppet/rvm
BSD 3-Clause "New" or "Revised" License
32 stars 103 forks source link

Drop Windows support #176

Closed bastelfreak closed 2 years ago

bastelfreak commented 2 years ago

The gnupg module doesn't support windows. Also we cannot run tests on windows.. This is cherry-picked from #164

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ekohl commented 2 years ago

Oh, I was so trigger happy but:

$ rg -i windows
manifests/system_user.pp
6:  if $facts['os']['family'] == 'Windows' {
7:    fail('rvm::system_user is not supported on Windows')

manifests/params.pp
4:    'Windows' => false,

spec/defines/system_user_spec.rb
13:      if os_facts[:osfamily] == 'windows'
14:        it { is_expected.to compile.and_raise_error(%r{rvm::system_user is not supported on Windows}) }

Will you clean this up later?