search

voxpupuli / puppet-rvm

A puppet module for installing and using RVM (Ruby Version Manager)
https://forge.puppet.com/puppet/rvm
BSD 3-Clause "New" or "Revised" License
32 stars 103 forks source link

Perform full line matching in rvm_system_ruby #183

Closed ekohl closed 2 years ago

ekohl commented 2 years ago

Rather than seeing if the line contains the name this checks if the whole line matches. This can also avoid problems where ruby-x.y.1 could match ruby-x.y.10.

Replacement for https://github.com/voxpupuli/puppet-rvm/pull/124. I'm relying on CI to tell me if this is a good change.

ekohl commented 2 years ago

Looks like this breaks idempotency when you specify just jruby (as our tests do), which previously worked. So for now I'm not going to pursue this further.