search

voxpupuli / puppet-selinux

Puppet Module to manage SELinux on RHEL machines
https://forge.puppet.com/puppet/selinux
Apache License 2.0
48 stars 148 forks source link

Update legacy facts #404

Open voreilly opened 2 weeks ago

voreilly commented 2 weeks ago

Affected Puppet, Ruby, OS and module versions/distributions

How to reproduce (e.g Puppet code you use)

Use mod 'benjaminrobertson-find_legacy_facts', '0.2.0' and run again an environment on your puppet master node

What are you seeing

File: selinux/lib/puppet/provider/selinux_fcontext/semanage.rb contains legacy fact selinux on line 10 File: selinux/lib/puppet/provider/selinux_fcontext_equivalence/semanage.rb contains legacy fact selinux on line 9 File: selinux/lib/puppet/provider/selinux_permissive/semanage.rb contains legacy fact selinux on line 8 File: selinux/lib/puppet/provider/selinux_port/semanage.rb contains legacy fact selinux on line 8 File: selinux/lib/puppet/provider/selinux_login/semanage.rb contains legacy fact selinux on line 8

What behaviour did you expect instead

Please use os.selinux.enabled instead of just selinux

Output log

Any additional information you'd like to impart

voreilly commented 2 weeks ago

Also forgot to add in one more legacy fact: selinux/lib/facter/selinux_python_command.rb contains legacy fact osfamily on line 5; use os.family

kenyon commented 2 weeks ago

Can you provide a pull request? Thanks!

voreilly commented 2 weeks ago

Sure kenyon, just created a pull request. Cheers