This commit puts a defined in cache_dir.pp

voxpupuli / puppet-squid

Puppet module for configuration of squid caching proxy.

https://forge.puppet.com/puppet/squid

Other

12 stars 54 forks source link

This commit puts a defined in cache_dir.pp #115

Closed ralfbosz closed 5 years ago

ralfbosz commented 5 years ago

Making it possible to create your own cache_dir outside of the Squid module. Fixing issue #108.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

ralfbosz commented 5 years ago

Not the biggest fan of ensure_resource. Found it not working sometimes (when the parameters do not match) it gives me errors. But will change it to ensure_resource.

ekohl commented 5 years ago

In https://github.com/voxpupuli/puppet-squid/pull/116 an explicit parameter for this was added. I prefer this and think this PR can be closed now. If you disagree, it at least needs the conflict to be resolved :)

ralfbosz commented 5 years ago

Even better implementation, closing this one...